Clean up some code related to QueryVTable::execute_query_fn#153120
Merged
rust-bors[bot] merged 3 commits intorust-lang:mainfrom Feb 26, 2026
Merged
Clean up some code related to QueryVTable::execute_query_fn#153120rust-bors[bot] merged 3 commits intorust-lang:mainfrom
QueryVTable::execute_query_fn#153120rust-bors[bot] merged 3 commits intorust-lang:mainfrom
Conversation
All three of these functions were previously taking `cache` and `execute_query_fn` as separate arguments, but after some other recent simplifications we can just pass `&'tcx QueryVTable<'tcx, C>` instead. This makes it easier to see where `execute_query_fn` is actually called.
rustbot
added
A-query-system
nnethercote
reviewed
Feb 26, 2026
Contributor
|
Looks fine, one nit. r=me after considering/addressing that. |
This function is tricky to document, and there's more that could be said here, but I don't want to take up too much vertical space, or add too much risk of details becoming inaccurate over time.
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 26, 2026
Clean up some code related to `QueryVTable::execute_query_fn` This PR is an assortment of small cleanups to code that interacts with `execute_query_fn` in the query vtable. I also experimented with trying to replace the macro-generated `__rust_end_short_backtrace` functions with a single shared generic function, but I couldn't manage to avoid breaking short backtraces, so I left a note behind to document my attempt. r? nnethercote (or compiler)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
…uwer Rollup of 7 pull requests Successful merges: - #153079 (Revert "Move aarch64-apple dist builder to dynamic llvm linking") - #152651 (Avoid duplicate `requirement` diag args in `RegionOriginNote`) - #152978 (Port `#[rustc_autodiff]` to the attribute parser infrastructure) - #153091 (Migration of `LintDiagnostic` - part 4) - #153112 (Query key cleanups) - #153118 (mailmap: add redddy) - #153120 (Clean up some code related to `QueryVTable::execute_query_fn`)
rust-timer
added a commit
that referenced
this pull request
Feb 26, 2026
Rollup merge of #153120 - Zalathar:execute, r=nnethercote Clean up some code related to `QueryVTable::execute_query_fn` This PR is an assortment of small cleanups to code that interacts with `execute_query_fn` in the query vtable. I also experimented with trying to replace the macro-generated `__rust_end_short_backtrace` functions with a single shared generic function, but I couldn't manage to avoid breaking short backtraces, so I left a note behind to document my attempt. r? nnethercote (or compiler)
Contributor
|
@rust-timer build 122a72d |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (122a72d): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -9.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 3.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 480.132s -> 480.506s (0.08%) |
Member
Author
|
I'm surprised to see this have any perf effect. Maybe we're just perturbing LLVM's inlining heuristics? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an assortment of small cleanups to code that interacts with
execute_query_fnin the query vtable.I also experimented with trying to replace the macro-generated
__rust_end_short_backtracefunctions with a single shared generic function, but I couldn't manage to avoid breaking short backtraces, so I left a note behind to document my attempt.r? nnethercote (or compiler)