implementation of -Z min-recursion-limit#153188
Open
Kivooeo wants to merge 1 commit intorust-lang:mainfrom
Open
implementation of -Z min-recursion-limit#153188Kivooeo wants to merge 1 commit intorust-lang:mainfrom
-Z min-recursion-limit#153188Kivooeo wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
jieyouxu
reviewed
Feb 27, 2026
jieyouxu
reviewed
Feb 27, 2026
rust-cloud-vms
bot
force-pushed
the
min-rec-limit
branch
2 times, most recently
from
9b49e75 to
cc20487
Compare
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
min-rec-limit
branch
from
cc20487 to
71b3811
Compare
lcnr
reviewed
Feb 27, 2026
Comment on lines
38
to
39
| .max(find_attr!(attrs, RecursionLimit { limit, .. } => limit.0)) | ||
| .unwrap_or(128), |
Contributor
There was a problem hiding this comment.
It's weird that providing min_recursion_limit can actually lower the used recursion limit. I would go with .max(Some(find_attr!(attrs, RecursionLimit { limit, .. } => limit.0).unwrap_or(128)) 🤔
Member
Author
There was a problem hiding this comment.
agree, also added a test for this
lcnr
reviewed
Feb 27, 2026
lcnr
reviewed
Feb 27, 2026
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
min-rec-limit
branch
from
71b3811 to
2dbe5d4
Compare
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
min-rec-limit
branch
from
2dbe5d4 to
03796aa
Compare
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
min-rec-limit
branch
from
03796aa to
0406358
Compare
Member
Author
|
@rustbot ready |
rust-cloud-vms
bot
force-pushed
the
min-rec-limit
branch
from
0406358 to
e77e533
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
impl of rust-lang/compiler-team#969
r? lcnr