Skip to content

Fix compile error in std::fs impl on VEXos target#153246

Open
lewisfm wants to merge 1 commit intorust-lang:mainfrom
vexide:fix/fs-dir
Open

Fix compile error in std::fs impl on VEXos target#153246
lewisfm wants to merge 1 commit intorust-lang:mainfrom
vexide:fix/fs-dir

Conversation

@lewisfm
Copy link
Contributor

@lewisfm lewisfm commented Mar 1, 2026

This PR fixes a compile error in the standard library on the armv7a-vex-v5 target that was caused by there not being a version of the Dir struct exported from std::sys::fs::vexos. Reading from directories isn't supported on this platform, so the module now re-exports the unsupported version of Dir.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 1, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 1, 2026

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, joboet

@lewisfm lewisfm changed the title Export Dir from std::fs impl on VEXos target Fix compile error in std::fs impl on VEXos target Mar 1, 2026
@joboet
Copy link
Member

joboet commented Mar 1, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 1, 2026

📌 Commit 04f6a49 has been approved by joboet

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants