Conversation
This comment has been minimized.
This comment has been minimized.
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
r? @davidtwco rustbot has assigned @davidtwco. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
b12bea5 to
9375f85
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
9375f85 to
c757f7a
Compare
|
r? @oli-obk |
|
|
This comment has been minimized.
This comment has been minimized.
c757f7a to
ab792af
Compare
| /// Function to check if we can generate an async drop here | ||
| fn check_if_can_async_drop(&mut self, drop_ty: Ty<'tcx>, call_destructor_only: bool) -> bool { | ||
| let is_async_drop_feature_enabled = if self.tcx().features().async_drop() { | ||
| true |
There was a problem hiding this comment.
could do if self.tcx().features().staged_api() { span_bug!(some_span, "don't use async drop in libstd, it becomes insta-stable") } (and similarly at the other use of async_drop in adt_constructor
|
if you write |
ab792af to
2414f6d
Compare
fixes #142572
Again, I've been talking in the Zulip about this: #wg-async > is there a way I can help with Async Drop? @ 💬
TL;DR: This is going to be a bit of a refactor, hold your horses
Also, I might end up splitting this into two PRs, so I can first merge my elaborate_drop.rs refactor, and then my fix for the crash later, but IDK yet