Cleanup of c-variadic link test#153309
Open
folkertdev wants to merge 2 commits intorust-lang:mainfrom
Open
Conversation
rustbot
added
A-run-make
folkertdev
commented
Mar 2, 2026
| @@ -10,7 +10,7 @@ | |||
| use run_make_support::{cc, extra_c_flags, run, rustc, static_lib_name}; | |||
|
|
|||
| fn main() { | |||
| rustc().input("checkrust.rs").run(); | |||
| rustc().edition("2021").input("checkrust.rs").run(); | |||
Contributor
Author
There was a problem hiding this comment.
Needed for c"string literals".
| continue_if!(ap.arg::<c_long>() == 12); | ||
| continue_if!(ap.arg::<c_int>() == 'a' as c_int); | ||
| continue_if!(ap.arg::<c_double>().floor() == 6.18f64.floor()); | ||
| continue_if!(compare_c_str(ap.arg::<*const c_char>(), "Hello")); | ||
| continue_if!(ap.arg::<c_double>() == 6.28f64); |
Contributor
Author
There was a problem hiding this comment.
I suspect the floor was used due to this typo in the value of tau. Clearly c-variadic functions should not truncate floating point numbers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes pulled out of #152980 that are just cosmetic, but will help make the code run on embedded targets.
r? jieyouxu