Open
Conversation
By not pushing any crates to each_linked_rlib_for_lto when no cross-crate LTO is used, we can avoid special cases elsewhere.
It is still not entirely correct I think, but much closer to the current way things are done.
Collaborator
|
Some changes occurred in compiler/rustc_codegen_gcc |
Collaborator
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
13 tasks
Contributor
|
Before we introduce more LTO changes, would it be possible to fix this issue introduced by your previous LTO change please? It would be nice to also add a test for this specific scenario in the Rust CI. |
Member
Author
|
I missed that comment. Will take a look. |
Member
Author
|
@rustbot block until cg_gcc is unblocked |
Member
Author
|
@rustbot blocked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThinLtoInputto correctly handle incr comp caching.Linkertype from cg_llvm. It previously helped deduplicate code for-Zcombine-cgus, but that flag no longer exists.Part of rust-lang/compiler-team#908