Fallback to fat LTO for -Clto=thin in cg_gcc#153503
Open
bjorn3 wants to merge 1 commit intorust-lang:mainfrom
Open
Fallback to fat LTO for -Clto=thin in cg_gcc#153503bjorn3 wants to merge 1 commit intorust-lang:mainfrom
bjorn3 wants to merge 1 commit intorust-lang:mainfrom
Conversation
Fallback to no LTO doesn't work in practice as Cargo asks rustc to produce LTO-only rlibs with -Clinker-plugin-lto without providing any indication if they will be used for thin or fat LTO, so we can't disable -Clinker-plugin-lto for ThinLTO when using cg_gcc.
rustbot
added
S-waiting-on-review
antoyo
approved these changes
Mar 6, 2026
Member
Author
|
@bors r=antoyo |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 7, 2026
…=antoyo Fallback to fat LTO for -Clto=thin in cg_gcc Fallback to no LTO doesn't work in practice as Cargo asks rustc to produce LTO-only rlibs with -Clinker-plugin-lto without providing any indication if they will be used for thin or fat LTO, so we can't disable -Clinker-plugin-lto for ThinLTO when using cg_gcc. r? @antoyo
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 7, 2026
…uwer Rollup of 5 pull requests Successful merges: - #149937 (spliit out `linker-info` from `linker-messages`) - #153503 (Fallback to fat LTO for -Clto=thin in cg_gcc) - #153346 (move never type tests to subdirectories and add some comments) - #153371 (Fix LegacyKeyValueFormat report from docker build: arm) - #153508 (Clean up the eager formatting API)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fallback to no LTO doesn't work in practice as Cargo asks rustc to produce LTO-only rlibs with -Clinker-plugin-lto without providing any indication if they will be used for thin or fat LTO, so we can't disable -Clinker-plugin-lto for ThinLTO when using cg_gcc.
r? @antoyo