Add macro matcher for guard fragment specifier#153702
Open
SpriteOvO wants to merge 1 commit intorust-lang:mainfrom
Open
Add macro matcher for guard fragment specifier#153702SpriteOvO wants to merge 1 commit intorust-lang:mainfrom
guard fragment specifier#153702SpriteOvO wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
The parser was modified, potentially altering the grammar of (stable) Rust cc @fmease |
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use Why was this reviewer chosen?The reviewer was selected based on:
|
4 tasks
This comment has been minimized.
This comment has been minimized.
b39f0f3 to
dc0fa6b
Compare
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue #153104
This PR implements a new
guardmacro matcher to matchif-letguards (specificallyMatchArmGuard). In the upcoming PR, we can use this new matcher in thematches!andassert_matches!macros to support their use withif-letguards. (see #152313)The original
Exprused to represent a guard has been wrapped in a newGuardtype, allowing us to carry the span information of the leadingifkeyword. However, it might be even better to include theifkeyword in theGuardtype as well? I've left a FIXME comment in the code.