de-non_const Iterator trait methods#153708
Open
Lars-Schumann wants to merge 1 commit intorust-lang:mainfrom
Open
de-non_const Iterator trait methods#153708Lars-Schumann wants to merge 1 commit intorust-lang:mainfrom
Iterator trait methods#153708Lars-Schumann wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @scottmcm rustbot has assigned @scottmcm. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Lars-Schumann
changed the title
Iterator trait methods
Lars-Schumann
force-pushed
the
de-non_const-iterator-trait-methods
branch
from
5e438b4 to
2960e3a
Compare
oli-obk
reviewed
Mar 11, 2026
|
|
||
| impl<I: Iterator<Item: IntoIterator>> Flatten<I> { | ||
| pub(in super::super) fn new(iter: I) -> Flatten<I> { | ||
| #[rustc_const_unstable(feature = "const_iter", issue = "92476")] |
Contributor
There was a problem hiding this comment.
Why does this one need stability attrs but none of the other constructor functions do?
oli-obk
reviewed
Mar 11, 2026
| { | ||
| default fn spec_advance_by(&mut self, n: usize) -> Result<(), NonZero<usize>> { | ||
| for i in 0..n { | ||
| // FIXME(const-hack): this should be `for i in 0..n` |
Contributor
There was a problem hiding this comment.
Maybe we should figure that one out first 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#92476
constifying Iterators methods that don't immediately or transitively need const closures or ugly hacks.