Rollup of 3 pull requests#153812
Merged
rust-bors[bot] merged 6 commits intorust-lang:mainfrom Mar 13, 2026
Merged
Conversation
Also move the FIXME to the source code to avoid duplication, and also suppress harmless warnings that are annoying when you compile manually.
…youxu tests/debuginfo/basic-stepping.rs: Add lldb test Also move the FIXME to the source code to avoid duplication, and also suppress harmless warnings that are annoying when you compile manually. Takes us one step closer towards closing rust-lang#33013.
Add a `TaggedQueryKey` to identify a query instance This adds back a `TaggedQueryKey` enum which represents a query kind and the associated key. This is used to replace `QueryStackDeferred` and `QueryStackFrameExtra` and the associated lifting operation for cycle errors This approach has a couple of benefits: - We only run description queries when printing the query stack trace in the panic handler - The unsafe code for `QueryStackDeferred` is removed - Cycle handles have access to query keys, which may be handy Some further work could be replacing `QueryStackFrame` with `TaggedQueryKey` as the extra information can be derived from it.
…nslation-test, r=jieyouxu rustfmt.toml: drop ignore of deleted test
rustbot
added
A-meta
Member
Author
|
Rollup of everything. @bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 7ad5c60 (parent) -> eaf4e74 (this PR) Test differencesNo test diffs found Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard eaf4e7489b6ae3d4ba9a71b720b03b6d58e4f102 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced Mar 13, 2026
Collaborator
|
Finished benchmarking commit (eaf4e74): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.5%, secondary -6.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 488.372s -> 481.06s (-1.50%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
TaggedQueryKeyto identify a query instance #153492 (Add aTaggedQueryKeyto identify a query instance)r? @ghost
Create a similar rollup