Avoid prematurely choosing a glob import#153912
Open
mu001999 wants to merge 1 commit intorust-lang:mainfrom
Open
Avoid prematurely choosing a glob import#153912mu001999 wants to merge 1 commit intorust-lang:mainfrom
mu001999 wants to merge 1 commit intorust-lang:mainfrom
Conversation
… with current import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153842
Use the following without introducing trait to explain:
In current implementation, when
#1is first resolved,crate::xis temporarily taken from glob import#3ascrate::b::x. This happens becausesingle_import_can_define_namewill see that#2cannot definex(because it depends on#1and#1is ignored) and then returnfalse. Later, during finalization,crate::xin#1resolves through single import#2instead, which no longer matches the initially cached modulecrate::b::xand triggers the ICE.I think the resolver should keep this unresolved because
#2may still definexto avoid prematurely choosing a glob import.r? petrochenkov