Skip to content

Add missing num_internals feature gate to coretests/benches#154132

Open
bjorn3 wants to merge 1 commit intorust-lang:mainfrom
bjorn3:fix_missing_feature_gate
Open

Add missing num_internals feature gate to coretests/benches#154132
bjorn3 wants to merge 1 commit intorust-lang:mainfrom
bjorn3:fix_missing_feature_gate

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Mar 20, 2026

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 20, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 20, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Fallback group: @Mark-Simulacrum, @jieyouxu
  • @Mark-Simulacrum, @jieyouxu expanded to Mark-Simulacrum, jieyouxu
  • Random selection from Mark-Simulacrum, jieyouxu

@lqd
Copy link
Member

lqd commented Mar 20, 2026

2 questions:

  • the patch has two changes, but this PR has one?
  • if this feature gate is only used in the cg_clif benches/tests, we should say as such in a comment, otherwise someone could remove it as being unused, right?

@bjorn3
Copy link
Member Author

bjorn3 commented Mar 20, 2026

the patch has two changes, but this PR has one?

The other change was already done upstream by someone else.

if this feature gate is only used in the cg_clif benches/tests, we should say as such in a comment, otherwise someone could remove it as being unused, right?

It is not. I suspect the reason it doesn't fail in Rust's CI is benches not being tested at all in CI.

@rust-log-analyzer

This comment has been minimized.

@bjorn3 bjorn3 force-pushed the fix_missing_feature_gate branch from 482c64c to 5ef93c1 Compare March 20, 2026 11:22
@jieyouxu
Copy link
Member

r? libs

@rustbot rustbot assigned Mark-Simulacrum and unassigned jieyouxu Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants