Skip to content

Do not attempt generating imports for extern types#154147

Open
mati865 wants to merge 1 commit intorust-lang:mainfrom
mati865:raw-dylib-extern-types
Open

Do not attempt generating imports for extern types#154147
mati865 wants to merge 1 commit intorust-lang:mainfrom
mati865:raw-dylib-extern-types

Conversation

@mati865
Copy link
Member

@mati865 mati865 commented Mar 20, 2026

Fixes #154111

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 20, 2026
@mati865 mati865 marked this pull request as ready for review March 20, 2026 18:28
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 20, 2026

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 12 candidates

Comment on lines +1 to +6
//@ only-elf
//@ ignore-cross-compile: Runs a binary.
//@ needs-dynamic-linking
// FIXME(raw_dylib_elf): Debug the failures on other targets.
//@ only-gnu
//@ only-x86_64
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a copy from other raw-dylib-elf tests.
I don't know if we can make it run on both Windows and ELF && gnu && x86_64 at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: Unexpected type for raw-dylib: foreign type

3 participants