ui/lto: move and rename two tests from issues/

[ujjwalvishwakarma2006]

Move:

• tests/ui/issues/issue-44056.rs -> tests/ui/lto/lto-avx-target-feature.rs
  • The first test enables both AVX target features and LTO but does not exercise AVX-specific behavior. The test primarily checks that LTO builds successfully with these flags; place it under ui/lto for consistency.
• tests/ui/issues/issue-51947.rs -> tests/ui/lto/lto-weak-merge-functions.rs
  • The second test exercises weak linkage interacting with LTO (merge-functions), so it should belong in ui/lto.

I have also added a commented line at the top of each test file indicating the issue it originated from.

[zedddie]

hey! usually you'd split these into separate commits (check this discussion) and add a comment at the top referencing the original issue, something like //! regression test for <https://github.com/rust-lang/rust/issues/XXXXX>.

[ujjwalvishwakarma2006]

@zedddie Oh. Sorry, I wasn't aware of this. I thought I should consolidate as many files as possible into a single commit so that they don't clutter commits that actually fix some bugs or add features.

Also, isn't it inefficient? Because after every commit, the "internal tool" runs some checks, and it takes about an hour to execute those checks.

BTW, I have made changes in the top comment.

[zedddie]

Oh. Sorry, I wasn't aware of this

It's totally fine! You aren't supposed to know everything beforehand.

Also, isn't it inefficient? Because after every commit, the "internal tool" runs some checks, and it takes about an hour to execute those checks.

I believe the tidy check should run as pre-push hook, not after each commit. I can suggest you looking at this chapter of rustc-dev-guide for more info!

[zedddie]

BTW, I have made changes in the top comment.

Oops maybe what I said wasn't really clear, I meant adding this lines to the top of the renamed test files.
So for example test tests/ui/issues/issue-44056, after renaming would loss metadata about the issue it originates from, so you should add the line at the top of a test file:

//! regression test for <https://github.com/rust-lang/rust/issues/44056>
//@ build-pass (FIXME(55996): should be run on targets supporting avx)
//@ only-x86_64
//@ no-prefer-dynamic
//@ compile-flags: -Ctarget-feature=+avx -Clto
//@ ignore-backends: gcc

fn main() {}

not PR description.
You can check this PR to have a picture of how workflow is done usually.

[ujjwalvishwakarma2006]

@zedddie
I have made the changes following the steps mentioned in the discussion. Kindly review.

[Kivooeo]

FYI: We're discouraging using Copilot for reviews. Once IT completes its review, Copilot-generated messages will be hidden as spam.

[ujjwalvishwakarma2006]

FYI: We're discouraging using Copilot for reviews. Once IT completes its review, Copilot-generated messages will be hidden as spam.

I don't know why the Copilot review started automatically. Who is responsible for changing this functionality - the contributor or the organization? Do I need to disable the Copilot reviewer?

If yes, let me fix this in future commits.

Edit: I got the answer, it's in my hands ( :

[Kivooeo]

Yep, this should be in your settings -- we've already disabled automatic Copilot reviews.