Skip to content

Rollup of 4 pull requests#154186

Closed
JonathanBrouwer wants to merge 8 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-X8uH6iG
Closed

Rollup of 4 pull requests#154186
JonathanBrouwer wants to merge 8 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-X8uH6iG

Conversation

@JonathanBrouwer
Copy link
Contributor

Successful merges:

r? @ghost

Create a similar rollup

folkertdev and others added 8 commits March 19, 2026 14:39
Avoid an ICE for:

    struct A;
    impl A<B> {}

The compiler no longer panics and can proceed to emit existing diagnostics.

Adds `tests/ui/missing/undeclared-generic-parameter.rs`.

Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
…, r=petrochenkov

Packages as namespaces part 1

Part 1 of rust-lang#152299

r? @petrochenkov
… r=sayantn

add neon load/store assembly test

I'm adding this test because it was requested for the beta backport of rust-lang#153336. We'd like to test this with Miri, but currently there is no load/store pair that roundtrips because one or the other still uses the platform-specific intrinsics.

r? sayantn

I believe test-various runs some arm and android tests?

@bors try job=test-various
…ulacrum

Add new alias for Guillaume Gomez email address

I'm switching to a new email account and slowly updating all references to the old one.
…tebank

diagnostics: avoid ICE for undeclared generic parameter in impl

Avoid an ICE for:

    struct A;
    impl A<B> {}

The compiler no longer panics and can proceed to emit existing diagnostics.

Adds `tests/ui/missing/undeclared-generic-parameter.rs`.

Fixes rust-lang#154165 and introduced by rust-lang#152913
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Mar 21, 2026
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 21, 2026
@JonathanBrouwer
Copy link
Contributor Author

@bors r+ rollup=never p=5

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 21, 2026

📌 Commit afa0eef has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2026
@JonathanBrouwer
Copy link
Contributor Author

Trying commonly failed jobs
@bors try jobs=test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Mar 21, 2026
Rollup of 4 pull requests


try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-apple failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [assembly] tests/assembly-llvm/aarch64-arm-load-store.rs#AARCH64 stdout ----
------FileCheck stdout------------------------------

------FileCheck stderr------------------------------
/Users/runner/work/rust/rust/tests/assembly-llvm/aarch64-arm-load-store.rs:27:14: error: AARCH64: expected string not found in input
 // AARCH64: ld3 { v0.4s, v1.4s, v2.4s }, [x0]
             ^
/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/assembly-llvm/aarch64-arm-load-store.AARCH64/aarch64-arm-load-store.s:3:24: note: scanning from here
 .globl _test_vld3q_f32
                       ^
/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/assembly-llvm/aarch64-arm-load-store.AARCH64/aarch64-arm-load-store.s:7:2: note: possible intended match here
 ld3.4s { v0, v1, v2 }, [x0]
 ^
/Users/runner/work/rust/rust/tests/assembly-llvm/aarch64-arm-load-store.rs:46:14: error: AARCH64: expected string not found in input
 // AARCH64: ld3 { v0.4s, v1.4s, v2.4s }, [x0]
             ^
/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/assembly-llvm/aarch64-arm-load-store.AARCH64/aarch64-arm-load-store.s:13:24: note: scanning from here
 .globl _test_vld3q_s32
                       ^
/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/assembly-llvm/aarch64-arm-load-store.AARCH64/aarch64-arm-load-store.s:17:2: note: possible intended match here
 ld3.4s { v0, v1, v2 }, [x0]
 ^
/Users/runner/work/rust/rust/tests/assembly-llvm/aarch64-arm-load-store.rs:65:14: error: AARCH64: expected string not found in input
 // AARCH64: ld3 { v0.4s, v1.4s, v2.4s }, [x0]
             ^
/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/assembly-llvm/aarch64-arm-load-store.AARCH64/aarch64-arm-load-store.s:23:24: note: scanning from here
 .globl _test_vld3q_u32
                       ^
/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/assembly-llvm/aarch64-arm-load-store.AARCH64/aarch64-arm-load-store.s:27:2: note: possible intended match here
 ld3.4s { v0, v1, v2 }, [x0]
 ^

Input file: /Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/assembly-llvm/aarch64-arm-load-store.AARCH64/aarch64-arm-load-store.s
Check file: /Users/runner/work/rust/rust/tests/assembly-llvm/aarch64-arm-load-store.rs

-dump-input=help explains the following input dump.

Input was:
<<<<<<
            1:  .build_version macos, 11, 0 
            2:  .section __TEXT,__text,regular,pure_instructions 
            3:  .globl _test_vld3q_f32 
check:27'0                            X error: no match found
            4:  .p2align 2 
check:27'0     ~~~~~~~~~~~~
            5: _test_vld3q_f32: 
check:27'0     ~~~~~~~~~~~~~~~~~
            6:  .cfi_startproc 
check:27'0     ~~~~~~~~~~~~~~~~
            7:  ld3.4s { v0, v1, v2 }, [x0] 
check:27'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:27'1      ?                            possible intended match
            8:  stp q0, q1, [x8] 
check:27'0     ~~~~~~~~~~~~~~~~~~
            9:  str q2, [x8, #32] 
check:27'0     ~~~~~~~~~~~~~~~~~~~
           10:  ret 
check:27'0     ~~~~~
           11:  .cfi_endproc 
check:27'0     ~~~~~~~~~~~~~~
           12:  
check:27'0     ~
           13:  .globl _test_vld3q_s32 
check:27'0     ~~~~~~~~~~~~~~~~~~~~~~~
check:46'0                            X error: no match found
           14:  .p2align 2 
check:46'0     ~~~~~~~~~~~~
           15: _test_vld3q_s32: 
check:46'0     ~~~~~~~~~~~~~~~~~
           16:  .cfi_startproc 
check:46'0     ~~~~~~~~~~~~~~~~
           17:  ld3.4s { v0, v1, v2 }, [x0] 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:46'1      ?                            possible intended match
           18:  stp q0, q1, [x8] 
check:46'0     ~~~~~~~~~~~~~~~~~~
           19:  str q2, [x8, #32] 
check:46'0     ~~~~~~~~~~~~~~~~~~~
           20:  ret 
check:46'0     ~~~~~
           21:  .cfi_endproc 
check:46'0     ~~~~~~~~~~~~~~
           22:  
check:46'0     ~
           23:  .globl _test_vld3q_u32 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~
check:65'0                            X error: no match found
           24:  .p2align 2 
check:65'0     ~~~~~~~~~~~~
           25: _test_vld3q_u32: 
check:65'0     ~~~~~~~~~~~~~~~~~
           26:  .cfi_startproc 
check:65'0     ~~~~~~~~~~~~~~~~
           27:  ld3.4s { v0, v1, v2 }, [x0] 
check:65'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:65'1      ?                            possible intended match
           28:  stp q0, q1, [x8] 
check:65'0     ~~~~~~~~~~~~~~~~~~
           29:  str q2, [x8, #32] 
check:65'0     ~~~~~~~~~~~~~~~~~~~
           30:  ret 
check:65'0     ~~~~~
           31:  .cfi_endproc 
check:65'0     ~~~~~~~~~~~~~~
           32:  
check:65'0     ~
           33: .subsections_via_symbols 
check:65'0     ~~~~~~~~~~~~~~~~~~~~~~~~~
>>>>>>

------------------------------------------

error in revision `AARCH64`: verification with 'FileCheck' failed
status: exit status: 1
command: "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/llvm/build/bin/FileCheck" "--input-file" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/assembly-llvm/aarch64-arm-load-store.AARCH64/aarch64-arm-load-store.s" "/Users/runner/work/rust/rust/tests/assembly-llvm/aarch64-arm-load-store.rs" "--check-prefix=CHECK" "--check-prefix" "AARCH64" "--allow-unused-prefixes" "--dump-input-context" "100"
stdout: none
--- stderr -------------------------------
/Users/runner/work/rust/rust/tests/assembly-llvm/aarch64-arm-load-store.rs:27:14: error: AARCH64: expected string not found in input
 // AARCH64: ld3 { v0.4s, v1.4s, v2.4s }, [x0]
             ^
/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/assembly-llvm/aarch64-arm-load-store.AARCH64/aarch64-arm-load-store.s:3:24: note: scanning from here
 .globl _test_vld3q_f32
                       ^
/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/assembly-llvm/aarch64-arm-load-store.AARCH64/aarch64-arm-load-store.s:7:2: note: possible intended match here
 ld3.4s { v0, v1, v2 }, [x0]
 ^
/Users/runner/work/rust/rust/tests/assembly-llvm/aarch64-arm-load-store.rs:46:14: error: AARCH64: expected string not found in input
 // AARCH64: ld3 { v0.4s, v1.4s, v2.4s }, [x0]
             ^
/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/assembly-llvm/aarch64-arm-load-store.AARCH64/aarch64-arm-load-store.s:13:24: note: scanning from here
 .globl _test_vld3q_s32
                       ^
/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/assembly-llvm/aarch64-arm-load-store.AARCH64/aarch64-arm-load-store.s:17:2: note: possible intended match here
 ld3.4s { v0, v1, v2 }, [x0]
 ^
/Users/runner/work/rust/rust/tests/assembly-llvm/aarch64-arm-load-store.rs:65:14: error: AARCH64: expected string not found in input
 // AARCH64: ld3 { v0.4s, v1.4s, v2.4s }, [x0]
             ^
/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/assembly-llvm/aarch64-arm-load-store.AARCH64/aarch64-arm-load-store.s:23:24: note: scanning from here
 .globl _test_vld3q_u32
                       ^
/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/assembly-llvm/aarch64-arm-load-store.AARCH64/aarch64-arm-load-store.s:27:2: note: possible intended match here
 ld3.4s { v0, v1, v2 }, [x0]
 ^

Input file: /Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/assembly-llvm/aarch64-arm-load-store.AARCH64/aarch64-arm-load-store.s
Check file: /Users/runner/work/rust/rust/tests/assembly-llvm/aarch64-arm-load-store.rs

-dump-input=help explains the following input dump.

Input was:
<<<<<<
            1:  .build_version macos, 11, 0 
            2:  .section __TEXT,__text,regular,pure_instructions 
            3:  .globl _test_vld3q_f32 
check:27'0                            X error: no match found
            4:  .p2align 2 
check:27'0     ~~~~~~~~~~~~
            5: _test_vld3q_f32: 
check:27'0     ~~~~~~~~~~~~~~~~~
            6:  .cfi_startproc 
check:27'0     ~~~~~~~~~~~~~~~~
            7:  ld3.4s { v0, v1, v2 }, [x0] 
check:27'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:27'1      ?                            possible intended match
            8:  stp q0, q1, [x8] 
check:27'0     ~~~~~~~~~~~~~~~~~~
            9:  str q2, [x8, #32] 
check:27'0     ~~~~~~~~~~~~~~~~~~~
           10:  ret 
check:27'0     ~~~~~
           11:  .cfi_endproc 
check:27'0     ~~~~~~~~~~~~~~
           12:  
check:27'0     ~
           13:  .globl _test_vld3q_s32 
check:27'0     ~~~~~~~~~~~~~~~~~~~~~~~
check:46'0                            X error: no match found
           14:  .p2align 2 
check:46'0     ~~~~~~~~~~~~
           15: _test_vld3q_s32: 
check:46'0     ~~~~~~~~~~~~~~~~~
           16:  .cfi_startproc 
check:46'0     ~~~~~~~~~~~~~~~~
           17:  ld3.4s { v0, v1, v2 }, [x0] 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:46'1      ?                            possible intended match
           18:  stp q0, q1, [x8] 
check:46'0     ~~~~~~~~~~~~~~~~~~
           19:  str q2, [x8, #32] 
check:46'0     ~~~~~~~~~~~~~~~~~~~
           20:  ret 
check:46'0     ~~~~~
           21:  .cfi_endproc 
check:46'0     ~~~~~~~~~~~~~~
           22:  
check:46'0     ~
           23:  .globl _test_vld3q_u32 
check:46'0     ~~~~~~~~~~~~~~~~~~~~~~~
check:65'0                            X error: no match found
           24:  .p2align 2 
check:65'0     ~~~~~~~~~~~~
           25: _test_vld3q_u32: 
check:65'0     ~~~~~~~~~~~~~~~~~
           26:  .cfi_startproc 
check:65'0     ~~~~~~~~~~~~~~~~
           27:  ld3.4s { v0, v1, v2 }, [x0] 
check:65'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:65'1      ?                            possible intended match
           28:  stp q0, q1, [x8] 
check:65'0     ~~~~~~~~~~~~~~~~~~
           29:  str q2, [x8, #32] 
check:65'0     ~~~~~~~~~~~~~~~~~~~
           30:  ret 
check:65'0     ~~~~~
           31:  .cfi_endproc 
check:65'0     ~~~~~~~~~~~~~~
           32:  
check:65'0     ~
           33: .subsections_via_symbols 
check:65'0     ~~~~~~~~~~~~~~~~~~~~~~~~~
>>>>>>

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 21, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 21, 2026

PR #154094, which is a member of this rollup, was unapproved.

This rollup was thus unapproved.

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 21, 2026
@rust-bors rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 21, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 21, 2026

💔 Test for 6f1d78f failed: CI. Failed job:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants