Improve inline assembly error messages#154228
Open
folkertdev wants to merge 1 commit intorust-lang:mainfrom
Open
Improve inline assembly error messages#154228folkertdev wants to merge 1 commit intorust-lang:mainfrom
folkertdev wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @nnethercote rustbot has assigned @nnethercote. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Kivooeo
approved these changes
Mar 22, 2026
This comment has been minimized.
This comment has been minimized.
by - using `DiagSymbolList` to get nicely formatted lists - mentioning the `modifier` when an invalid modifier is used. This is useful in case the span cannot be resolved (which I ran into).
folkertdev
force-pushed
the
mention-invalid-template-modifier
branch
from
4d34630 to
6f08437
Compare
nnethercote
approved these changes
Mar 22, 2026
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by
DiagSymbolListto get nicely formatted listsmodifierwhen an invalid modifier is used. This is useful in case the span cannot be resolved (which I ran into).