Skip to content

Allow applying autodiff macros to trait functions.#154245

Open
ZuseZ4 wants to merge 1 commit intorust-lang:mainfrom
ZuseZ4:autodiff-trait-support
Open

Allow applying autodiff macros to trait functions.#154245
ZuseZ4 wants to merge 1 commit intorust-lang:mainfrom
ZuseZ4:autodiff-trait-support

Conversation

@ZuseZ4
Copy link
Member

@ZuseZ4 ZuseZ4 commented Mar 23, 2026

It will use enzyme to generate a default derivative implementation, which can be overwritten by the user.

closes: #153329

r? @JonathanBrouwer

@rustbot
Copy link
Collaborator

rustbot commented Mar 23, 2026

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 23, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 23, 2026

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

@ZuseZ4 ZuseZ4 force-pushed the autodiff-trait-support branch from 05fc1d3 to 0f8b016 Compare March 23, 2026 10:06
It will use enzyme to generate a default derivative implementation,
which can be overwritten by the user.
@ZuseZ4 ZuseZ4 force-pushed the autodiff-trait-support branch from 0f8b016 to 26c9f72 Compare March 23, 2026 10:27
@jdonszelmann
Copy link
Contributor

r? me

@jdonszelmann
Copy link
Contributor

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 23, 2026

📌 Commit 26c9f72 has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2026
@jdonszelmann
Copy link
Contributor

actually, @bors r-
r=me on green ci

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 23, 2026
@JonathanBrouwer
Copy link
Contributor

@bors r=JonathanBrouwer,jdonszelmann rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 23, 2026

📌 Commit 26c9f72 has been approved by JonathanBrouwer,jdonszelmann

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 23, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 23, 2026
…onathanBrouwer,jdonszelmann

Allow applying autodiff macros to trait functions.

It will use enzyme to generate a default derivative implementation, which can be overwritten by the user.

closes: rust-lang#153329

r? @JonathanBrouwer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enable autodiff as a default trait impl

5 participants