Skip to content

allow incomplete_features in all ui tests#154331

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
cyrgani:incomplete-3
Mar 25, 2026
Merged

allow incomplete_features in all ui tests#154331
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
cyrgani:incomplete-3

Conversation

@cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Mar 24, 2026

This PR allows the incomplete_features lint for the specialization directory, thereby allowing it for all UI tests.

Followup to #154174 and #154276.
Closes #154168.

@rustbot
Copy link
Collaborator

rustbot commented Mar 24, 2026

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 24, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 24, 2026

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 13 candidates

Copy link
Contributor

@JonathanBrouwer JonathanBrouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup
Great work, thanks! Also thanks for doing these in separate PRs, makes things a lot easier to review

View changes since this review

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 24, 2026

📌 Commit 97e84d5 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 24, 2026
…ouwer

allow `incomplete_features` in all ui tests

This PR allows the `incomplete_features` lint for the `specialization` directory, thereby allowing it for all UI tests.

Followup to rust-lang#154174 and rust-lang#154276.
Closes rust-lang#154168.
rust-bors bot pushed a commit that referenced this pull request Mar 24, 2026
…uwer

Rollup of 3 pull requests

Successful merges:

 - #154311 ([libcore] Disable `doc(auto_cfg)` for integers trait impls)
 - #154331 (allow `incomplete_features` in all ui tests)
 - #154336 (Remove more BuiltinLintDiag variants - part 3)
@rust-bors rust-bors bot merged commit 22f3a5d into rust-lang:main Mar 25, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 25, 2026
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Mar 25, 2026
…uwer

Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#154311 ([libcore] Disable `doc(auto_cfg)` for integers trait impls)
 - rust-lang/rust#154331 (allow `incomplete_features` in all ui tests)
 - rust-lang/rust#154336 (Remove more BuiltinLintDiag variants - part 3)
@cyrgani cyrgani deleted the incomplete-3 branch March 25, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking issue for MCP 974: allow incomplete_features in UI tests

4 participants