delegation: don't propagate synthetic params, remove lifetime hacks#154364
Open
aerooneqq wants to merge 1 commit intorust-lang:mainfrom
Open
delegation: don't propagate synthetic params, remove lifetime hacks#154364aerooneqq wants to merge 1 commit intorust-lang:mainfrom
aerooneqq wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
aerooneqq
commented
Mar 25, 2026
This comment has been minimized.
This comment has been minimized.
aerooneqq
changed the title
aerooneqq
force-pushed
the
delegation-generics-small-fixes
branch
from
48edf69 to
c2383b5
Compare
Contributor
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 25, 2026
…l-fixes, r=petrochenkov delegation: don't propagate synthetic params, remove lifetime hacks Some small fixes after new delegation lowering was merged: remove lifetime hacks as now we get only early-bound lifetimes from generics, don't propagate synthetic generic params as now we know that they are synthetic. Fixes rust-lang#143498. Part of rust-lang#118212. r? @petrochenkov
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 25, 2026
…l-fixes, r=petrochenkov delegation: don't propagate synthetic params, remove lifetime hacks Some small fixes after new delegation lowering was merged: remove lifetime hacks as now we get only early-bound lifetimes from generics, don't propagate synthetic generic params as now we know that they are synthetic. Fixes rust-lang#143498. Part of rust-lang#118212. r? @petrochenkov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small fixes after new delegation lowering was merged: remove lifetime hacks as now we get only early-bound lifetimes from generics, don't propagate synthetic generic params as now we know that they are synthetic. Fixes #143498. Part of #118212.
r? @petrochenkov