Skip to content

large_enums mir pass: fix is_enabled logic#154375

Open
RalfJung wants to merge 1 commit intorust-lang:mainfrom
RalfJung:large_enums
Open

large_enums mir pass: fix is_enabled logic#154375
RalfJung wants to merge 1 commit intorust-lang:mainfrom
RalfJung:large_enums

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 25, 2026

This logic got turned from a guard in run_pass to an is_enabled check in 15d4728#r2989096960, but that was done incorrectly. The pass must never be enabled without unsound_mir_opts!

@rustbot
Copy link
Collaborator

rustbot commented Mar 25, 2026

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 25, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 25, 2026

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, mir, mir-opt
  • compiler, mir, mir-opt expanded to 69 candidates
  • Random selection from 12 candidates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants