Skip to content

Rollup of 3 pull requests#154390

Merged
rust-bors[bot] merged 7 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-y369aHY
Mar 26, 2026
Merged

Rollup of 3 pull requests#154390
rust-bors[bot] merged 7 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-y369aHY

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Mar 25, 2026

sayantn and others added 7 commits February 25, 2026 06:50
….rs and tests/ui/drop/drop-noncopyable-raw-pointer.rs
Require avxvnni for avx10.2

AVX10.2 supports masked (and 512-bit) versions of some intrinsics available in AVXVNNI, AVXVNNIINT8 and AVXVNNIINT16 (e.g. AVX10.2 introduces `_mm{,256,512}_{mask{z}}_dpbuud_epi32` corresponding to `_mm{,256}_dpbuud_epi32` from AVXVNNIINT8). But Intel (being Intel), didn't (at least not in SDM) enforce that AVX10.2 (or at least AVX10_VNNI_INT, which is a "discrete AVX10 feature", introduced alongside AVX10.2, and expected to house more such instructions) requires AVXVNNI etc.

To make this (admittedly very Intel) situation a bit better, we can just require these features from the Rust frontend

r? @Amanieu

This also corrects a mistake in std-detect which allowed AVX10 to be enabled without AVX512F, in the (odd) case when F16C or FMA are not available (we require these for AVX512F because otherwise the LLVM assembler doesn't work)
…ests, r=Kivooeo

Migrate UI tests

In this pull request, I am migrating the following files and adding a comment at the top, including a link to the issue they were regression tests for:
- `tests/ui/issues/issue-4735.rs` ➝ `tests/ui/drop/drop-noncopyable-raw-pointer.rs`
- `tests/ui/issues/issue-17734.rs` ➝ `tests/ui/codegen/box-str-drop-glue.rs`

r? Kivooeo
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Mar 25, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 25, 2026
@JonathanBrouwer
Copy link
Contributor Author

@bors r+ rollup=never p=5

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 25, 2026

📌 Commit c8d729b has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 26, 2026

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 7m 30s
Pushing 6d8bc65 to main...

@rust-bors rust-bors bot merged commit 6d8bc65 into rust-lang:main Mar 26, 2026
12 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 26, 2026
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 1174f78 (parent) -> 6d8bc65 (this PR)

Test differences

Show 13 test diffs

Stage 1

  • [ui] tests/ui/codegen/box-str-drop-glue.rs: [missing] -> pass (J1)
  • [ui] tests/ui/coherence/generalize-associated-type-alias.rs: [missing] -> pass (J1)
  • [ui] tests/ui/drop/drop-noncopyable-raw-pointer.rs: [missing] -> pass (J1)
  • [ui] tests/ui/issues/issue-17734.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-4735.rs: pass -> [missing] (J1)

Stage 2

  • [ui] tests/ui/codegen/box-str-drop-glue.rs: [missing] -> pass (J0)
  • [ui] tests/ui/coherence/generalize-associated-type-alias.rs: [missing] -> pass (J0)
  • [ui] tests/ui/drop/drop-noncopyable-raw-pointer.rs: [missing] -> pass (J0)
  • [ui] tests/ui/issues/issue-17734.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-4735.rs: pass -> [missing] (J0)

Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 6d8bc65fc851433b0c17e5530ca68ff7eb41815c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 1h 29m -> 1h 49m (+22.0%)
  2. pr-check-1: 28m 4s -> 33m 49s (+20.5%)
  3. x86_64-gnu-debug: 1h 48m -> 2h 7m (+17.7%)
  4. x86_64-gnu-tools: 52m 53s -> 1h 1m (+16.5%)
  5. aarch64-gnu-debug: 1h 8m -> 1h 19m (+16.3%)
  6. i686-gnu-2: 1h 31m -> 1h 43m (+13.7%)
  7. optional-x86_64-gnu-parallel-frontend: 2h 22m -> 2h 40m (+12.4%)
  8. x86_64-gnu-gcc: 1h 2m -> 1h 10m (+12.2%)
  9. x86_64-rust-for-linux: 47m 12s -> 52m 51s (+12.0%)
  10. test-various: 1h 56m -> 2h 10m (+11.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6d8bc65): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.2% [-4.2%, -4.2%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 483.566s -> 483.836s (0.06%)
Artifact size: 395.05 MiB -> 395.09 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants