Take first task group for further execution#154419
Take first task group for further execution#154419zetanumbers wants to merge 1 commit intorust-lang:mainfrom
Conversation
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
I wonder what variance, and noise level, you're seeing on your benchmarking machine? BTZ, does this remove some small overhead a few times, or does it translate to good results on bigger benchmarks as well? |
|
@rustbot reroll |
Here's baseline compiler running against itself:
I have run these benchmarks on various changes before and never seen all greens like above. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Continuing from #153768 (comment).
I thought that storing a first group of tasks for immediate execution instead of pushing and immediately poping it from rayon's local task queue in par_slice would avoid overwhelming work stealing potentially blocking the original thread. So I've implemented this change.
8 threads benchmarks: