Migrate transmute tests#154425
Draft
ujjwalvishwakarma2006 wants to merge 4 commits intorust-lang:mainfrom
Draft
Conversation
rustbot
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made the following changes in this PR:
tests/ui/issues/issue-28625.rs➝tests/ui/transmute/transmute-associated-type-to-slice.rstests/ui/issues/issue-28625.stderr➝tests/ui/transmute/transmute-associated-type-to-slice.stderrtests/ui/issues/issue-23477.rs➝tests/ui/transmute/transmute-slice-to-dst.rsThe reason I changed the trait name from
trait Bartotrait MyTraitandtype Bartotype MyTypeis that the same name (i.e.,Bar) for the trait and associated type was making it harder to follow the test. It was confusing for me, at least.As the policy says to disclose the use of LLMs.
I used LLMs a bit to understand the code. Here are the links to chats:
r? Kivooeo