Skip to content

Set up API to make it possible to pass closures instead of AttributeLint#154432

Open
GuillaumeGomez wants to merge 2 commits intorust-lang:mainfrom
GuillaumeGomez:try-rm-AttributeLint
Open

Set up API to make it possible to pass closures instead of AttributeLint#154432
GuillaumeGomez wants to merge 2 commits intorust-lang:mainfrom
GuillaumeGomez:try-rm-AttributeLint

Conversation

@GuillaumeGomez
Copy link
Member

Part of #153099.

This PR sets up the base implementations needed to remove AttributeLintKind entirely and migrate two variants as examples.

r? @JonathanBrouwer

@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2026

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 26, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2026

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-21 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   |
80 | pub mod lints;
   | ^^^^^^^^^^^^^^
   |
   = help: to create the module `lints`, create file "compiler/rustc_errors/src/lints.rs" or "compiler/rustc_errors/src/lints/mod.rs"
   = note: if there is a `mod lints` elsewhere in the crate already, import it with `use crate::...` instead

For more information about this error, try `rustc --explain E0583`.
[RUSTC-TIMING] rustc_errors test:false 0.247
warning: `rustc_errors` (lib) generated 1 warning
error: could not compile `rustc_errors` (lib) due to 1 previous error; 1 warning emitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants