resolve: Some import resolution cleanups#154435
Open
petrochenkov wants to merge 4 commits intorust-lang:mainfrom
Open
resolve: Some import resolution cleanups#154435petrochenkov wants to merge 4 commits intorust-lang:mainfrom
petrochenkov wants to merge 4 commits intorust-lang:mainfrom
Conversation
Avoid two of its uses in diagnostic reporting and effective visibility collection. The method is only supposed to be used inside the import resolution algorithm, and the removed uses happened after import resolution already converged. Some comments are also added.
Using `self.(non_)glob_decl` directly makes it more clear.
Using `self.(non_)glob_decl` directly makes it more clear.
It is no longer needed to pass import validation, and the removal avoids some secondary errors. Also add a couple of asserts
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
petrochenkov
commented
Mar 26, 2026
| mod empty {} | ||
| use empty::issue_56125; //~ ERROR unresolved import `empty::issue_56125` | ||
| use issue_56125::*; //~ ERROR `issue_56125` is ambiguous | ||
| use issue_56125::*; |
Contributor
Author
There was a problem hiding this comment.
The glob prefix now unambiguously resolves to the erroneous use empty::issue_56125 during error reporting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the individual commits