Fix invalid type suggestion for item nested in function#154540
Open
chenyukang wants to merge 1 commit intorust-lang:mainfrom
Open
Fix invalid type suggestion for item nested in function#154540chenyukang wants to merge 1 commit intorust-lang:mainfrom
chenyukang wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
chenyukang
changed the title
Contributor
|
I'm pretty sure there are many other suggestions where we should be using this macro. We should figure out a way of automating it for the @bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 29, 2026
…ble-path-suggestion, r=estebank Fix invalid type suggestion for item nested in function Fixes rust-lang#146786 I also tried to add the `omit_parent` logic in pretty formatter here: https://github.com/chenyukang/rust/blob/69b6d26d05006dca7556abc555fb0e029ecf1f4e/compiler/rustc_middle/src/ty/print/pretty.rs#L2240-L2295 so that we don't need to add `should_omit_parent_def_path` and `reset_path`. but seems there will be duplicate print code with `default_print_def_path`. maybe r? @estebank
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146786
I also tried to add the
omit_parentlogic in pretty formatter here:https://github.com/chenyukang/rust/blob/69b6d26d05006dca7556abc555fb0e029ecf1f4e/compiler/rustc_middle/src/ty/print/pretty.rs#L2240-L2295
so that we don't need to add
should_omit_parent_def_pathandreset_path.but seems there will be duplicate print code with
default_print_def_path.maybe r? @estebank