Skip to content

Add --quiet flag to x.py and bootstrap to suppress output#154616

Open
erickt wants to merge 1 commit intorust-lang:mainfrom
erickt:quiet
Open

Add --quiet flag to x.py and bootstrap to suppress output#154616
erickt wants to merge 1 commit intorust-lang:mainfrom
erickt:quiet

Conversation

@erickt
Copy link
Copy Markdown
Contributor

@erickt erickt commented Mar 31, 2026

This adds a --quiet flag to x.py and bootstrap to suppress some of the output when compiling Rust. It works by passing the flag down to the underlying cargo, cmake, ninja, or make processes.

This adds a `--quiet` flag to x.py and bootstrap to suppress some of the
output when compiling Rust. It works by passing the flag down to the
underlying cargo, cmake, ninja, or make processes.
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 31, 2026

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 31, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 31, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Mark-Simulacrum

@jieyouxu
Copy link
Copy Markdown
Member

I can only look into these this weekend, but cc also #154587

(It would be nice to be careful that we don't use --quiet to mean different things)

@erickt
Copy link
Copy Markdown
Contributor Author

erickt commented Mar 31, 2026

Ha! What a coincidence. I’m certainly intending to have the same semantics as that PR, so I think they should be compatible with each other. I’m happy to wait for it to land since it beat me by a few hours, then I can match the style with whatever you finalize on.

@jieyouxu
Copy link
Copy Markdown
Member

(I think either one can land first, I was just remarking just in case we somehow have --quiet do two entirely different things which would be very confusing, but doesn't seem like the case)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants