Emit fatal on defaults for generic params in binders if with nested defs#154642
Open
mu001999 wants to merge 1 commit intorust-lang:mainfrom
Open
Emit fatal on defaults for generic params in binders if with nested defs#154642mu001999 wants to merge 1 commit intorust-lang:mainfrom
mu001999 wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
This PR changes a file inside |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #123629
Such defaults won't be lowered to hir, but the nested items would be. Then ICE will happen when later error handling walks HIR parents of inner items.
Similar to #154595