rustdoc: Improve internal function name#154728
Open
aDotInTheVoid wants to merge 1 commit intorust-lang:mainfrom
Open
rustdoc: Improve internal function name#154728aDotInTheVoid wants to merge 1 commit intorust-lang:mainfrom
aDotInTheVoid wants to merge 1 commit intorust-lang:mainfrom
Conversation
This functions name totally contradicted what it did. And the only places it was used immediatly `!`ed it. Push the `!` into the function, and rename it to make sense. Should hopefully result in less head-scratching next time someone looks at this.
rustbot
added
S-waiting-on-review
aDotInTheVoid
added
the
C-cleanup
GuillaumeGomez
approved these changes
Apr 2, 2026
Member
|
Oof, yeah that was a bad name. Thanks for the improvement! r=me once CI pass. |
Member
Author
|
@bors r=GuillaumeGomez rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Apr 3, 2026
… r=GuillaumeGomez rustdoc: Improve internal function name This functions name totally contradicted what it did. And the only places it was used immediatly `!`ed it. Push the `!` into the function, and rename it to make sense. Should hopefully result in less head-scratching next time someone looks at this. r? @GuillaumeGomez
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 3, 2026
Rollup of 6 pull requests Successful merges: - #154444 (rustdoc ICE fix: When collecting `Deref` impls with their targets, skip the negative ones) - #154590 (Make #[cfg] suggest any or all on #[cfg(a, b)]) - #154691 (core: Update the feature gate on `TryFrom<integer> for bool`) - #154697 (rustdoc: fix href of extern crates in search results) - #154728 (rustdoc: Improve internal function name) - #154732 (fix(std): avoid AT_MINSIGSTKSZ on uclibc targets) Failed merges: - #154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This functions name totally contradicted what it did. And the only places it was used immediatly
!ed it. Push the!into the function, and rename it to make sense.Should hopefully result in less head-scratching next time someone looks at this.
r? @GuillaumeGomez