Remove Clone impl for StableHashingContext.#154744
Draft
nnethercote wants to merge 1 commit intorust-lang:mainfrom
Draft
Remove Clone impl for StableHashingContext.#154744nnethercote wants to merge 1 commit intorust-lang:mainfrom
Clone impl for StableHashingContext.#154744nnethercote wants to merge 1 commit intorust-lang:mainfrom
Conversation
`HashStable::hash_stable` takes a `&mut Hcx`. In contrast, `ToStableHashKey::to_stable_hash_key` takes a `&Hcx`. But there are some places where the latter calls the former, and due to the mismatch a `clone` call is required to get a mutable `StableHashingContext`. This commit changes `to_stable_hash_key` to instead take a `&mut Hcx`. This eliminates the mismatch, the need for the clones, and the need for the `Clone` impls.
rustbot
added
S-waiting-on-author
Contributor
Author
|
@bors try @rust-timer queue |
Collaborator
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 3, 2026
…, r=<try> Remove `Clone` impl for `StableHashingContext`.
rustbot
added
the
S-waiting-on-perf
Contributor
Collaborator
|
Queued b67d172 with parent 55e86c9, future comparison URL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HashStable::hash_stabletakes a&mut Hcx. In contrast,ToStableHashKey::to_stable_hash_keytakes a&Hcx. But there are some places where the latter calls the former, and due to the mismatch aclonecall is required to get a mutableStableHashingContext.This commit changes
to_stable_hash_keyto instead take a&mut Hcx. This eliminates the mismatch, the need for the clones, and the need for theCloneimpls.