Skip to content

Avoid duplicate diagnostic args in RegionOriginNote::WithName#154875

Open
TaKO8Ki wants to merge 1 commit intorust-lang:mainfrom
TaKO8Ki:regression-test-152936-regions-name
Open

Avoid duplicate diagnostic args in RegionOriginNote::WithName#154875
TaKO8Ki wants to merge 1 commit intorust-lang:mainfrom
TaKO8Ki:regression-test-152936-regions-name

Conversation

@TaKO8Ki
Copy link
Copy Markdown
Member

@TaKO8Ki TaKO8Ki commented Apr 6, 2026 •
edited by rustbot
Loading

Fixes #152936

This is a follow up to #153508.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 6, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 6, 2026

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 10 candidates

@TaKO8Ki TaKO8Ki changed the title Add regions regression test for impl-trait lifetime conflict Add regression test for impl-trait lifetime conflict 152936 Apr 6, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@TaKO8Ki TaKO8Ki force-pushed the regression-test-152936-regions-name branch from 9e11eee to f497faf Compare April 6, 2026 09:31
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 6, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@TaKO8Ki
Copy link
Copy Markdown
Member Author

TaKO8Ki commented Apr 6, 2026

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2026
@TaKO8Ki TaKO8Ki force-pushed the regression-test-152936-regions-name branch from f497faf to 989f4cd Compare April 6, 2026 12:06
@TaKO8Ki TaKO8Ki changed the title Add regression test for impl-trait lifetime conflict 152936 Avoid duplicate diagnostic args in RegionOriginNote::WithName Apr 6, 2026
@TaKO8Ki
Copy link
Copy Markdown
Member Author

TaKO8Ki commented Apr 6, 2026

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 6, 2026
@jackh726
Copy link
Copy Markdown
Member

jackh726 commented Apr 6, 2026

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 6, 2026

📌 Commit 989f4cd has been approved by jackh726

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#154875 - TaKO8Ki:regression-test-152936-reg…
f149f40 
…ions-name, r=jackh726

Avoid duplicate diagnostic args in `RegionOriginNote::WithName`

Fixes rust-lang#152936

This is a follow up to rust-lang#153508.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 6, 2026
Open
rust-bors bot pushed a commit that referenced this pull request Apr 6, 2026
@bors
Auto merge of #154909 - JonathanBrouwer:rollup-44bqfTG, r=JonathanBro…
bcded33 
…uwer

Rollup of 2 pull requests

Successful merges:

 - #154875 (Avoid duplicate diagnostic args in `RegionOriginNote::WithName`)
 - #154898 (Use debug! instead of info!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jackh726 jackh726

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ICE]: arg name already exists

4 participants

@TaKO8Ki @rustbot @rust-log-analyzer @jackh726