attr parsing: make sure we pass the right target when errors could be emitted#154876
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 6, 2026
Merged
attr parsing: make sure we pass the right target when errors could be emitted#154876rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
scrabsha
commented
Apr 6, 2026
Contributor
Author
There was a problem hiding this comment.
all the changes in this file are for crate-level attributes, hence the Target::crate.
JonathanBrouwer
approved these changes
Apr 6, 2026
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-timer
added a commit
that referenced
this pull request
Apr 6, 2026
Rollup merge of #154876 - scrabsha:push-ymvvtywqttlq, r=JonathanBrouwer attr parsing: make sure we pass the right target when errors could be emitted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this while debugging something on #154590. AFAIK there is no user-observable change, but the code was definitely wrong (I tested it by adding an
assert!(matches!(should_emit, ShouldEmit::Nothing));at the beginning ofparse_limited_should_emit.I did a bit of archeology and it looks like this was introduced in #137729. I couldn't find any reason for this from the discussion that occurred back then.
r? jdonszelmann