Fix ICE in ptr_metadata_ty_or_tail for recursive associated types#154884
Open
RaghavenderSingh wants to merge 1 commit intorust-lang:mainfrom
Open
Fix ICE in ptr_metadata_ty_or_tail for recursive associated types#154884RaghavenderSingh wants to merge 1 commit intorust-lang:mainfrom
RaghavenderSingh wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @adwinwhite rustbot has assigned @adwinwhite. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
c31940d to
ca8316f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153431.
When a struct's tail field has a recursive associated type, normalization
overflows and
normalize_projection_termreturns a fresh inference variable(
TyVar) instead of the original alias. ThisTyVarescapesstruct_tail_rawand reaches
ptr_metadata_ty_or_tail, which had no arm for it and calledbug!.Fix by handling
ty::Infer(ty::TyVar(_))the same way asty::Error(_),return
Ok(tcx.types.unit)since the overflow error has already been reported.