Change hashing/comparison of LintExpectationId (fix ICE)

[Bryntet]

this fixes #154878 by removing attr_id from LintExpectationId and instead using target_span + attr_index + lint_index in combination to refer to a unique lint expectation

[rustbot]

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

[rustbot]

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 69 candidates
• Random selection from 10 candidates

[Bryntet]

I couldn't figure out how to make a regression test for this due to it needing the incremental cache, if you know how to I'd love to add it

[JonathanBrouwer]

Adding a regression test should be possible as an incremental test

View changes since this review

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[Bryntet]

@rustbot ready

added regression test and tested that it indeed does fail on main