compiletest: pass -Zunstable-options for unpretty and no-codegen paths#154993
Open
DeepeshWR wants to merge 1 commit intorust-lang:mainfrom
Open
compiletest: pass -Zunstable-options for unpretty and no-codegen paths#154993DeepeshWR wants to merge 1 commit intorust-lang:mainfrom
DeepeshWR wants to merge 1 commit intorust-lang:mainfrom
Conversation
Unconditionally pass -Zunstable-options in the `unpretty` and `-Zno-codegen` (typecheck) paths in compiletest. This ensures custom targets resolved via RUST_TARGET_PATH work consistently. This is primarily needed when using non-built-in targets without a .json extension. Signed-off-by: Deepesh Varatharajan <Deepesh.Varatharajan@windriver.com>
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
rustbot
added
the
T-bootstrap
Collaborator
|
r? @clubby789 rustbot has assigned @clubby789. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
cc @davidtwco |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using custom targets via
RUST_TARGET_PATH, compiletest does notconsistently pass
-Zunstable-optionsin all code paths.In particular,
unprettyand-Zno-codegen(typecheck) paths invokerustc without
-Zunstable-options, which causes failures when thetarget is not built-in.
Pass
-Zunstable-optionsin these code paths to ensure consistentbehavior when using custom targets.
This primarily affects setups using custom targets without
.jsonsuffix (resolved via
RUST_TARGET_PATH).