don't leak internal temporaries from dbg!#154994
Open
dianne wants to merge 1 commit intorust-lang:mainfrom
Open
don't leak internal temporaries from dbg!#154994dianne wants to merge 1 commit intorust-lang:mainfrom
dbg!#154994dianne wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Contributor
Author
dianne
added
the
beta-nominated
Member
|
We discussed this today in the libs meeting. We agree that reverting is the safer option for 1.95, given the late timing. However, this PR might also miss the 1.96 branch if it's not merged quickly, and then we probably will want a backport there. So, we're going to leave the nomination for now and see where things stand next week. |
Member
|
I've posted reverts in #154999 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154988
r? @Mark-Simulacrum as the reviewer of #154074