Skip to content

Implement GenericTypeVisitable for some types#155034

Open
ChayimFriedman2 wants to merge 1 commit intorust-lang:mainfrom
ChayimFriedman2:ra-fixes
Open

Implement GenericTypeVisitable for some types#155034
ChayimFriedman2 wants to merge 1 commit intorust-lang:mainfrom
ChayimFriedman2:ra-fixes

Conversation

@ChayimFriedman2
Copy link
Copy Markdown
Contributor

This is required for rust-analyzer.

r? types

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 9, 2026
Copy link
Copy Markdown
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after doing an arbitrary amount of work on the module comment

View changes since this review

@lcnr
Copy link
Copy Markdown
Contributor

lcnr commented Apr 9, 2026

@bors delegate+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 9, 2026

✌️ @ChayimFriedman2, you can now approve this pull request!

If @lcnr told you to "r=me" after making some further change, then please make that change and post @bors r=lcnr.

This is required for rust-analyzer.
@ChayimFriedman2
Copy link
Copy Markdown
Contributor Author

@bors r=lcnr

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 9, 2026

📌 Commit 6cd5315 has been approved by lcnr

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 9, 2026
Implement `GenericTypeVisitable` for some types

This is required for rust-analyzer.

r? types
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 9, 2026
Implement `GenericTypeVisitable` for some types

This is required for rust-analyzer.

r? types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants