Skip to content

Move tests from tests/ui/issues/ to appropriate directories#155058

Open
ujjwalvishwakarma2006 wants to merge 2 commits intorust-lang:mainfrom
ujjwalvishwakarma2006:move-tests
Open

Move tests from tests/ui/issues/ to appropriate directories#155058
ujjwalvishwakarma2006 wants to merge 2 commits intorust-lang:mainfrom
ujjwalvishwakarma2006:move-tests

Conversation

@ujjwalvishwakarma2006
Copy link
Copy Markdown
Contributor

@ujjwalvishwakarma2006 ujjwalvishwakarma2006 commented Apr 9, 2026

In this PR, I am moving the following test from tests/ui/issues directory to the appropriate directories, followed by the addition of issue links at the top and reblessing of the stderr files:

  • issue-3874.rstests/ui/binding/ref-in-let-lhs-in-field.rs
  • issue-4972.{rs,stderr}tests/ui/box/deref-borrowed-trait-object-in-box.{rs,stderr}

A more minimal version for the second test could be, in my opinion:

trait MyTrait {
    fn dummy(&self) {}
}

struct TraitWrapper(Box<dyn MyTrait + 'static>);

fn get_tw_map(tw: &TraitWrapper) -> &dyn MyTrait {
    match *tw {
        TraitWrapper(box ref map) => map,
    }
}

pub fn main() {}

Initially, I decided upon the following more descriptive names, but they were way too big:

  • issue-3874.rstests/ui/binding/ref-pattern-in-let-lhs-in-enum-field.rs
  • issue-4972.{rs,stderr}tests/ui/box/dereferencing-borrowed-trait-object-inside-box.{rs,stderr}

r? Kivooeo
r? Teapot4195

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 9, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 9, 2026

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 12 candidates

@rustbot rustbot assigned Kivooeo and unassigned mati865 Apr 9, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 9, 2026

Failed to set assignee to Teapot4195: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@ujjwalvishwakarma2006 ujjwalvishwakarma2006 changed the title Move tests Move tests from tests/ui/issues/ to appropriate directories Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants