Avoid mir_const_qualif ICE for invalid const trait methods#155070
Open
officialasishkumar wants to merge 1 commit intorust-lang:mainfrom
Open
Avoid mir_const_qualif ICE for invalid const trait methods#155070officialasishkumar wants to merge 1 commit intorust-lang:mainfrom
officialasishkumar wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches MIR const-qualification gating to use the body's actual const context instead of raw item constness for functions, associated functions, and closures.
That avoids calling
mir_const_qualiffor closures nested inside invalidconst fntrait methods, which previously ICEd after emitting E0379. Added a regression test.Fixes #153891.