Fix ICE in v0 symbol mangling for deeply nested generic types#155122
Open
GokhanKabar wants to merge 1 commit intorust-lang:mainfrom
Open
Fix ICE in v0 symbol mangling for deeply nested generic types#155122GokhanKabar wants to merge 1 commit intorust-lang:mainfrom
GokhanKabar wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
71fdd51 to
af904a7
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154965
When using
-C symbol-mangling-version=v0, pathologically nested generictype aliases cause the v0 mangler to emit a symbol so deeply nested that
rustc_demangleexceeds itsMAX_DEPTH = 500recursion limit and returnsErr. This trips thedebug_assert!incompute_symbol_name, producing an ICE.The fix mirrors the existing fallback for legacy mangling (which falls back
to v0 when symbols are too long for PDB): if the v0-mangled symbol cannot
be demangled, we fall back to hashed mangling, which always produces a
short, demanglable symbol.
A
build-passregression test is included.