Fix ICE when using attributes on delegation items#155146
Open
RaghavenderSingh wants to merge 1 commit intorust-lang:mainfrom
Open
Fix ICE when using attributes on delegation items#155146RaghavenderSingh wants to merge 1 commit intorust-lang:mainfrom
RaghavenderSingh wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Delegation items are skipped by `hir_walk_toplevel_module` (via `visit_if_delayed`), so they were never added to `delayed_lint_items`. This caused a debug assertion failure in `emit_ast_lowering_delayed_lints` when an attribute like `#[deprecated]` generated a delayed lint on the item. The FIXME in `ItemCollector::new` already noted this gap.
RaghavenderSingh
force-pushed
the
fix-ice-155127-delegation-delayed-lints
branch
from
140188d to
eed7d10
Compare
Member
|
It looks like you mentioned the wrong person. |
Author
Sorry about that, thanks! |
Member
|
@RaghavenderSingh When you explicitly need to pick up reviewers, you can do like |
Author
Thanks for the tip! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delegation items are skipped by
hir_walk_toplevel_module(viavisit_if_delayed), so they were never added todelayed_lint_items.This caused a debug assertion failure in
emit_ast_lowering_delayed_lintswhen an attribute like
#[deprecated]generated a delayed lint on the item.The FIXME in
ItemCollector::newalready noted this gap.Fixes #155127