Skip to content

Revert "allow windows-gnu targets to embed gdb visualizer scripts"#155281

Open
folkertdev wants to merge 1 commit intorust-lang:mainfrom
folkertdev:revert-154840
Open

Revert "allow windows-gnu targets to embed gdb visualizer scripts"#155281
folkertdev wants to merge 1 commit intorust-lang:mainfrom
folkertdev:revert-154840

Conversation

@folkertdev
Copy link
Copy Markdown
Contributor

Fixes #155277

This reverts commit 472b966.

This was merged as #154840, but causes linker errors in the wild.

cc @Walnut356 @mati865
r? @ghost

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 14, 2026

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 14, 2026
@jieyouxu
Copy link
Copy Markdown
Member

r? mati865 (so that this PR isn't lost)

@folkertdev
Copy link
Copy Markdown
Contributor Author

Sure, I was planning to just self-approve when CI is green (based on https://forge.rust-lang.org/compiler/reviews.html#reverts)

Copy link
Copy Markdown
Member

@mati865 mati865 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, something that isn't tested on the CI is not going to (non-spuriously) fail on CI 🙃.

View changes since this review

@folkertdev
Copy link
Copy Markdown
Contributor Author

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 14, 2026

📌 Commit 17f5fa0 has been approved by folkertdev

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 14, 2026
…tdev

Revert "allow `windows-gnu` targets to embed gdb visualizer scripts"

Fixes rust-lang#155277

This reverts commit 472b966.

This was merged as rust-lang#154840, but causes linker errors in the wild.

cc @Walnut356 @mati865
r? @ghost
rust-bors bot pushed a commit that referenced this pull request Apr 14, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #154049 (delegation: Track more precise spans for glob delegations)
 - #155134 (Replace custom trim_ascii_start with the standard library method)
 - #155235 (add the `fma4` x86 target feature)
 - #155218 (coroutines: Skip the closure signature annotation check for tainted bodies)
 - #155274 (limit duplicate-profiler-builtins test to targets that can do dynamic linking)
 - #155276 (`#[rustc_must_match_exhaustively]` detect let else)
 - #155281 (Revert "allow `windows-gnu` targets to embed gdb visualizer scripts")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multiple definition of .weak.rustc_debug_gdb_scripts_section.default on windows in stdarch CI

4 participants