[stable] Revert "Build shared LLVM lib for windows-gnullvm"#155283
Open
jieyouxu wants to merge 1 commit intorust-lang:stablefrom
Open
[stable] Revert "Build shared LLVM lib for windows-gnullvm"#155283jieyouxu wants to merge 1 commit intorust-lang:stablefrom
jieyouxu wants to merge 1 commit intorust-lang:stablefrom
Conversation
This reverts commit 1d1280a. Looks like this causes problems with certain LLVM bin tools not finding `libLLVM` on `*-windows-gnullvm`. This commit is a _minimal_ revert to return us to known state to alleviate time pressure to investigate.
This comment was marked as outdated.
This comment was marked as outdated.
rustbot
added
A-CI
Collaborator
|
Member
Author
|
r? @Mark-Simulacrum |
jieyouxu
commented
Apr 14, 2026
jieyouxu
force-pushed
the
revert-gnullvm-link-shared-stable
branch
from
a449c41 to
9b3eeb3
Compare
jieyouxu
changed the title
Member
|
Thanks. Do not wait for the artifacts, building them just to be 100% sure rather than 99.9%. @bors try jobs=dist-x86_64-llvm-mingw |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 14, 2026
…=<try> [stable] Revert "Build shared LLVM lib for windows-gnullvm" try-job: dist-x86_64-llvm-mingw
jieyouxu
added
stable-nominated
ZuseZ4
reviewed
Apr 14, 2026
| # i686 has no dedicated job, build it here because this job is fast | ||
| - name: dist-aarch64-llvm-mingw | ||
| env: | ||
| SCRIPT: python x.py dist bootstrap enzyme --include-default-paths |
Member
There was a problem hiding this comment.
Remove enzyme here and below. Otherwise it will fail, since (ATM) it requires dynamic linking
Member
There was a problem hiding this comment.
Is enzyme built on stable? I thought it's nightly only.
Member
There was a problem hiding this comment.
It's nightly only, but that would mean the next nightly build would still fail, even if a stable build in this config works, or?
Member
There was a problem hiding this comment.
This PR is targeting stable branch exclusively. LLVM DLL remains enabled on main branch.
Contributor
Member
|
Installed and tested using: Whereas on nightly this looks like this: So, indeed the issue is fixed. |
Member
|
@bors r+ rollup=never p=100 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 1d1280a.
Looks like this causes problems (#155268) with certain LLVM bin tools not finding
libLLVMon*-windows-gnullvm. This PR is a minimal revert to return us to known state to alleviate time pressure to investigate.