Remove AttributeSafety from BUILTIN_ATTRIBUTES#155354
Open
JonathanBrouwer wants to merge 1 commit intorust-lang:mainfrom
Open
Remove AttributeSafety from BUILTIN_ATTRIBUTES#155354JonathanBrouwer wants to merge 1 commit intorust-lang:mainfrom
JonathanBrouwer wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-attributes
JonathanBrouwer
force-pushed
the
attr-safety-port-2
branch
from
3b0ecee to
6236dde
Compare
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
S-waiting-on-review
Contributor
Author
|
@bors try jobs=i686-msvc-2 |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
Remove AttributeSafety from BUILTIN_ATTRIBUTES try-job: i686-msvc-2
Contributor
|
Looking forward to this! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encodes the expected attribute safety in the attribute parsers, rather than in
BUILTIN_ATTRIBUTES, with the goal of removingBUILTIN_ATTRIBUTESsoon.We can remove the old attribute safety logic already because unparsed attributes, just like the as of yet unparsed lint attributes, need to be safe.
r? @jdonszelmann (or @mejrs if you feel like doing it, since you are in T-compiler now 🎉)