Document panic in RangeInclusive::from(legacy::RangeInclusive)#155421
Open
tbu- wants to merge 1 commit intorust-lang:mainfrom
Open
Document panic in RangeInclusive::from(legacy::RangeInclusive)#155421tbu- wants to merge 1 commit intorust-lang:mainfrom
RangeInclusive::from(legacy::RangeInclusive)#155421tbu- wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @jhpratt rustbot has assigned @jhpratt. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
Has this been approved by T-libs-api? The panic message clearly says unspecified, so adding this documentation would overrule that. |
Contributor
Author
|
If T-libs doesn't want to guarantee this, I can change the wording to "currently panics, may not panic in the future". Or even "may panic". |
This comment has been minimized.
This comment has been minimized.
766773c to
f43e3e7
Compare
Member
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.