Fix; target feature inline always#155426
Open
Jamesbarford wants to merge 3 commits intorust-lang:mainfrom
Open
Fix; target feature inline always#155426Jamesbarford wants to merge 3 commits intorust-lang:mainfrom
Jamesbarford wants to merge 3 commits intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
Collaborator
|
r? @mejrs rustbot has assigned @mejrs. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
8b2613c to
ef34bce
Compare
7 tasks
This comment has been minimized.
This comment has been minimized.
ef34bce to
b269cc3
Compare
Contributor
|
This is pretty far out of my expertise, so r? compiler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for
#[inline(always)]with target featurestests/ui/target-feature/inline-always-vector-abi-global-avx.rs).sse2,ssse3 ... etcis missing if the user wroteavxon a function and the inlining logic bails because of a mismatch.Addresses concerns in #145574