Add temporary scope to assert_matches#155431
Open
Voultapher wants to merge 1 commit intorust-lang:mainfrom
Open
Add temporary scope to assert_matches#155431Voultapher wants to merge 1 commit intorust-lang:mainfrom
Voultapher wants to merge 1 commit intorust-lang:mainfrom
Conversation
Addresses rust-lang#154406 in part. assert_eq will be done in a separate PR.
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jhpratt rustbot has assigned @jhpratt. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
r? @Amanieu |
jieyouxu
reviewed
Apr 17, 2026
Comment on lines
+237
to
+238
| // Fails to compile if the macros don't introduce a temporary scope, since `&mut val` would | ||
| // create a second mutable borrow while `MutRefWithDrop` still holds a unique ref. |
Member
There was a problem hiding this comment.
Suggestion: consider adding a backlink to #154406 for extra context
dianne
reviewed
Apr 17, 2026
Comment on lines
+241
to
+243
| (assert_matches!(*MutRefWithDrop(&mut val).0, 0), std::mem::take(&mut val)); | ||
|
|
||
| (debug_assert_matches!(*MutRefWithDrop(&mut val).0, 0), std::mem::take(&mut val)); |
Contributor
There was a problem hiding this comment.
Since the expansions when there is and isn't a format string are defined separately, maybe it'd be worth having test cases for assert_matches! and debug_assert_matches! with a format string too?
dianne
added
the
beta-nominated
Contributor
|
Beta-nominating per #154406 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #154406 in part.
assert_eqwill be done in a separate PR.