rustdoc: Fix redundant_explicit_links incorrectly firing (or not firing) under certain scenarios#155435
Open
tonywu6 wants to merge 1 commit intorust-lang:mainfrom
Open
rustdoc: Fix redundant_explicit_links incorrectly firing (or not firing) under certain scenarios#155435tonywu6 wants to merge 1 commit intorust-lang:mainfrom
redundant_explicit_links incorrectly firing (or not firing) under certain scenarios#155435tonywu6 wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
rustbot has assigned @lolbinarycat. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
Thanks, and well done! @bors r+ rollup |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I found some issues with the
rustdoc::redundant_explicit_linkslint while working on a personal project.After skipping a link that contains inline markups, the lint would incorrectly skip all the remaining links.
For example, with the following snippet, the lint is fired for
[Option][Option], but not[Result][Result]:Happening because of a
?causing a loop to bail early:rust/src/librustdoc/passes/lint/redundant_explicit_links.rs
Line 107 in a4a37ed
The lint is fired for links that specify titles (like
[link](link "title")), except that wouldn't be applicable because it's not possible to specify a title without there also being an explicit target. For example:These are found as of:
(Note: I ran
./x test tests/rustdoc-uilocally, but not./x tidydue to my slow internet. There was an unrelated failed test attests/rustdoc-ui/ice-bug-report-url.rswhich I'm not sure about)