Skip to content

apply Cortex-A53 errata 843419 mitigation to the AArch64 Linux targets#155453

Open
japaric wants to merge 1 commit intorust-lang:mainfrom
ferrocene:a53-linux-fix-errata
Open

apply Cortex-A53 errata 843419 mitigation to the AArch64 Linux targets#155453
japaric wants to merge 1 commit intorust-lang:mainfrom
ferrocene:a53-linux-fix-errata

Conversation

@japaric
Copy link
Copy Markdown
Contributor

@japaric japaric commented Apr 17, 2026

as it's done for other AArch64 targets

although the linker (GCC) may be configured to apply the fix by default it's preferred to have rustc pass the flag to the linker to ensure the mitigation is always applied

for example, the Arm GNU toolchain does not enable the errata mitigation by default (checked version: 13.3.Rel1)

see #118095 for background information

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 17, 2026

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 17, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 17, 2026

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 72 candidates
  • Random selection from 18 candidates

@rustbot

This comment has been minimized.

as it's done for other AArch64 targets

although the linker (GCC) _may_ be configured to apply the fix by default it's
preferred to have rustc pass the flag to the linker to ensure the mitigation is
always applied

for example, the Arm GNU toolchain does _not_ enable the errata mitigation
by default (checked version: 13.3.Rel1)

see issue 118095 for background information
@japaric japaric force-pushed the a53-linux-fix-errata branch from 9bafb16 to a88c30d Compare April 17, 2026 16:55
Copy link
Copy Markdown
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

View changes since this review

@wesleywiser
Copy link
Copy Markdown
Member

@rustbot ping arm

Objections to merging this?

@rustbot rustbot added the O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state label Apr 17, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 17, 2026

Hey ARM Group! This issue has been identified as a good "ARM candidate".
In case it's useful, here are some instructions for tackling these sorts of
issues. Maybe take a look?
Thanks! <3

cc @adamgemmell @davidtwco @hug-dev @Jamesbarford @joaopaulocarreiro @lqd @raw-bin @Stammark

Xylakant pushed a commit to ferrocene/ferrocene that referenced this pull request Apr 17, 2026
as it's done for other AArch64 targets

although the linker (GCC) _may_ be configured to apply the fix by default it's
preferred to have rustc pass the flag to the linker to ensure the mitigation is
always applied

for example, the Arm GNU toolchain does _not_ enable the errata mitigation
by default (checked version: 13.3.Rel1)

see issue 118095 for background information

cherry-picked from upstream, see rust-lang/rust#155453 for details

re-enable the tests for this fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants