Rename incremental cfail/cpass revisions to bfail/bpass#155474
Open
Zalathar wants to merge 2 commits intorust-lang:mainfrom
Open
Rename incremental cfail/cpass revisions to bfail/bpass#155474Zalathar wants to merge 2 commits intorust-lang:mainfrom
cfail/cpass revisions to bfail/bpass#155474Zalathar wants to merge 2 commits intorust-lang:mainfrom
Conversation
Collaborator
|
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
Member
Author
|
Some of these revisions will be renamed back to |
jieyouxu
reviewed
Apr 18, 2026
This comment has been minimized.
This comment has been minimized.
Long ago, UI tests were divided into "compile" and "run" tests. Later, the compile tests were further subdivided into "check" and "build" tests, to speed up tests that don't need a full build. The same split was never applied to incremental test revisions, so the only way to perform a check build in incremental tests is (confusingly) to use a `cfail` revision and then specify `//@ check-fail` or `//@ check-pass`. This PR makes room for dedicated check-fail and check-pass revisions by renaming the existing `cfail` and `cpass` revisions to `bfail` and `bpass`, since they currently perform a full build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long ago, UI tests were divided into compile and run tests. Later, the compile tests were further subdivided into check and build tests, to speed up tests that don't need a full build.
The same split was never applied to incremental test revisions, so the only way to perform a check build in incremental tests is (confusingly) to use a
cfailrevision and then specify//@ check-failor//@ check-pass.This PR makes room for dedicated check-fail and check-pass revisions by renaming the existing
cfailandcpassrevisions tobfailandbpass, since they currently perform a full build.The test updates were done with a regex whole-word find-and-replace for
c(fail|pass)(\d*), and I also took the opportunity to manually add a space afterrevisions:on affected lines.r? jieyouxu